On Wed, 4 Sep 2024 20:10:54 GMT, Simon Tooke <sto...@openjdk.org> wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a
>> globally available API, i.e. adding it to the "Hotspot Porting API". Code
>> would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires the addition of a stub routine in os_posix.cpp and a Windows
>> implementation of realpath(), using Windows _fullpath().
>>
>> This PR depends on #20597 in that it removes the need for one #ifdef in that
>> PR. Because of that, this PR will be modified when and if #20597 is
>> integrated.
>>
>> Please note that guidelines for doing this appear in
>> src/hotspot/share/runtime/os.hpp
>
> Simon Tooke has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - simplify windwos realpath() implementation
> - get rid of os::posix::realpath() and os::win32::realpath()
Looks good, just 1 comment
src/hotspot/os/posix/os_posix.cpp line 1027:
> 1025: }
> 1026:
> 1027: char* os::Posix::realpath(const char* filename, char* outbuf, size_t
> outbuflen) {
I'm looking at this from the GitHub UI so I might be missing something, but why
was this moved up?
-------------
Marked as reviewed by jwaters (Committer).
PR Review: https://git.openjdk.org/jdk/pull/20683#pullrequestreview-2282462140
PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1745181260
