On Thu, 12 Sep 2024 15:40:35 GMT, Gerard Ziemski <gziem...@openjdk.org> wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`. >> >> `MEMFLAGS` implies that we can use more than one at the same time, but those >> are exclusive values, so `MemTag` is a more suitable name. >> >> This fix also includes a cleanup of all the related function/template >> parameter names and local variable names. >> >> Testing is pending... >> >> Note: there is more history in old closed PRs >> [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) >> and >> [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472) > > Gerard Ziemski has updated the pull request incrementally with two additional > commits since the last revision: > > - Afshin's feedback, record_virtual_memory_type -> record_virtual_memory_tag > - Afshin's feedback Johan's incremental feedback: https://openjdk.github.io/cr/?repo=jdk&pr=20872&range=06-07 Afshin's incremental feedback: https://openjdk.github.io/cr/?repo=jdk&pr=20872&range=07-08 https://openjdk.github.io/cr/?repo=jdk&pr=20872&range=08-09 ------------- PR Comment: https://git.openjdk.org/jdk/pull/20872#issuecomment-2346643064
