On Wed, 18 Sep 2024 05:07:33 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed ZERO build > > src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp line 170: > >> 168: log_error(cds)("Unable to resolve %s class from CDS archive: >> %s", category_name, ik->external_name()); >> 169: log_error(cds)("Expected: " INTPTR_FORMAT ", actual: " >> INTPTR_FORMAT, p2i(ik), p2i(actual)); >> 170: log_error(cds)("JVMTI class retransformation is not supported >> when archive was generated with -XX:+AOTClassLinking."); > > Nit: use a `logStream` instead of the three separate calls. Why? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1766119067