On Fri, 11 Oct 2024 21:20:55 GMT, William Kemper <[email protected]> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 535:
>>
>>> 533: ShenandoahPacer* pacer() const { return
>>> _pacer; }
>>> 534:
>>> 535: ShenandoahPhaseTimings* phase_timings() const { return
>>> _phase_timings; }
>>
>> The indentation is off here.
>
> I'll fix this, but I secretly don't like this style of formatting because it
> is slightly tedious to maintain. It also suggests that these methods are
> somehow grouped and formatted together for a reason beyond aesthetics.
https://bugs.openjdk.org/browse/JDK-8341992
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1797439929
