On Thu, 31 Oct 2024 20:14:43 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which is a JNI cleanup to replace incorrect usages of >> `jthrowable ExceptionOccurred(JNIEnv *env)` with `jboolean >> ExceptionCheck(JNIEnv *env)` in _jdk.hotspot.agent_. >> >> This is part of the bigger umbrella issue: >> https://bugs.openjdk.org/browse/JDK-8341542. This change only modifies >> instances where the exception object is not needed, and the method return >> value is being treated as if it were a boolean. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > for consistency, include the comments as well Looks good. Thanks ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21813#pullrequestreview-2409354612
