On Fri, 1 Nov 2024 07:53:20 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> The best way to get to the right answer here is simplify to the subject and >> verb: "failure fails". You don't put a comma between the subject and the >> verb, unless is something more much complex like "a failure, for which there >> can be more than one, fails the test". I think the reason you feel it reads >> better with the comma is because of the repetition of "fail". Would you >> still want a comma if the sentence was "any one protocol error fails the >> test"? I assume no, but the sentence is structurally identical. > > Right, it is the repetition that makes me want the comma. There are other > ways of phrasing this which would not need the comma. Even then, I still > might introduce one to imply a pause, which I still think helps make it > unambiguous on first read, without making it "...causes the test to fail" > which is unnecessarily lengthy. It's also a comment buried in a test, not > front page news. My 8th grade grammar teacher took no pity on students with "comma-itis" as he called it. They got penalized harshly for gratuitous use of commas. He definitely got through to me though. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21804#discussion_r1826091908
