On Fri, 8 Nov 2024 15:20:00 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
> Can I please get a review for this PR that add tests to verify the value of > `@since` tags to the Serviceability area modules. The test is described in > this > [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). > This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442. > > The benefit from this is helping API authors and reviewer validate the > accuracy of `@since` in their source code (and subsequently, in the generated > documentation). And lessen the burden on Reviewers. > > The test has been added for `java.base` and a few other modules and has > helped catch some bugs before they make it to the JDK. > > TIA test/jdk/tools/sincechecker/modules/jdk.jdwp.agent/JdkJdwpAgentCheckSince.java line 29: > 27: * @summary Test for @since in jdk.jdwp.agent module > 28: * @library /test/lib /test/jdk/tools/sincechecker > 29: * @run main SinceChecker jdk.jdwp.agent Just to say that there aren't any class files in jdk.jdwp but it does have a module-info.class, does the `@since` checker look at module-info too? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21983#discussion_r1834601770
