Looks like EmptyDomainNotificationTest has been working by accident for nearly 
20 years.
Removing notifications when not specifying a domain part of the ObjectName has 
actually been failing, but calling removeNotificationListener() without a 
domain has not been sharing the Exception.

ServerNotifForwarder.removeNotificationListener DOES need to add a domain part 
to an ObjectName that does not have one.

ServerNotifForwarder.addNotificationListener was changed in JDK-6238731, which 
is what this test is testing.

There is a numeric ID, BUT it still calls removeNotificationListener(ObjectName 
name, Integer listenerID) it does matter that the ObjectName does not match.

Maybe the failure to record and throw the Exceptions was the reason it was 
thought the numeric ID made the domain unnecessary.

-------------

Commit messages:
 - 8343838: Test EmptyDomainNotificationTest.java fails with 
ListenerNotFoundException

Changes: https://git.openjdk.org/jdk/pull/21993/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21993&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343838
  Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21993.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21993/head:pull/21993

PR: https://git.openjdk.org/jdk/pull/21993

Reply via email to