On Tue, 12 Nov 2024 14:25:30 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 503 commits: >> >> - Merge openjdk/jdk tip into great-genshen-pr-redux >> - Merge remote-tracking branch 'jdk/master' into merge-latest >> - Merge remote-tracking branch 'jdk/master' into merge-latest >> - Merge >> - 8342861: GenShen: Old generation in unexpected state when abandoning >> mixed gc candidates >> >> Reviewed-by: kdnilsen >> - 8342734: GenShen: Test failure >> gc/shenandoah/TestReferenceRefersToShenandoah.java#generational >> >> Reviewed-by: ysr >> - 8342919: GenShen: Fix whitespace >> >> Reviewed-by: xpeng, kdnilsen >> - 8342927: GenShen: Guarantee slices of time for coalesce and filling >> >> Reviewed-by: kdnilsen >> - 8342924: GenShen: Problem list >> gc/shenandoah/TestReferenceRefersToShenandoah.java >> >> Reviewed-by: kdnilsen, ysr >> - 8342848: Shenandoah: Marking bitmap may not be completely cleared in >> generational mode >> >> Reviewed-by: wkemper >> - ... and 493 more: https://git.openjdk.org/jdk/compare/1c448347...19b25bc3 > > test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java line 61: > >> 59: // case that the previously instantiated NastyThread >> accumulated more than SheanndoahNoProgressThreshold >> 60: // unproductive GC cycles before failing, the main >> thread may not try a Full GC before it experiences >> 61: // OutOfMemoryError exception. > > Do you really need comments in this test? This test was a sore spot for us and we spent quite some time to make it pass. I don't think the code is very clear on its face about what the test expects, so I'd prefer to keep this comment. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1841302676
