On Wed, 13 Nov 2024 11:01:59 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 503 commits: >> >> - Merge openjdk/jdk tip into great-genshen-pr-redux >> - Merge remote-tracking branch 'jdk/master' into merge-latest >> - Merge remote-tracking branch 'jdk/master' into merge-latest >> - Merge >> - 8342861: GenShen: Old generation in unexpected state when abandoning >> mixed gc candidates >> >> Reviewed-by: kdnilsen >> - 8342734: GenShen: Test failure >> gc/shenandoah/TestReferenceRefersToShenandoah.java#generational >> >> Reviewed-by: ysr >> - 8342919: GenShen: Fix whitespace >> >> Reviewed-by: xpeng, kdnilsen >> - 8342927: GenShen: Guarantee slices of time for coalesce and filling >> >> Reviewed-by: kdnilsen >> - 8342924: GenShen: Problem list >> gc/shenandoah/TestReferenceRefersToShenandoah.java >> >> Reviewed-by: kdnilsen, ysr >> - 8342848: Shenandoah: Marking bitmap may not be completely cleared in >> generational mode >> >> Reviewed-by: wkemper >> - ... and 493 more: https://git.openjdk.org/jdk/compare/1c448347...19b25bc3 > > src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp line 118: > >> 116: #ifdef ASSERT >> 117: assert(_union_tag != is_uninitialized, "Cannot fetch region from >> uninialized RegionData"); >> 118: #endif > > Style: No point in wrapping single-line `assert`-s in `#ifdef ASSERT`. https://bugs.openjdk.org/browse/JDK-8344151 > src/hotspot/share/gc/shenandoah/shenandoahVMOperations.hpp line 41: > >> 39: // - VM_ShenandoahInitUpdateRefs: initiate update references >> 40: // - VM_ShenandoahFinalUpdateRefs: finish up update references >> 41: // - VM_ShenandoahFinalRoots > > If we add it here, let's provide a comment: > > > // - VM_ShenandoahFinalRoots: finish up the roots, shortcut cycle https://bugs.openjdk.org/browse/JDK-8344151 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1841320875 PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1841320596
