On Thu, 14 Nov 2024 13:20:23 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env); >> >> I think this is obsolete too. > >> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env); >> >> I think this is obsolete too. > > As part of the JEP 486 work, I changed SecurityManager::getClassContext to > use StackWalker, the native method that called into JVM_GetClassContext is > removed. So more cleanup here. > @AlanBateman there was that AccessControlContext in the stack that I asked > about in the main review that I can't find the answer to. Is it obsolete now? > See the change for where I asked this question. Thank you! The stack walk that stopped when it found a privileged frame is removed. I can't think of any scenario now where the VM will be interested in the AccessControlContext. Also AccessController is re-implemented to just invoke the actions so there should be no reason for the VM to know about AccessController either. Note that we need to keep JVM_EnsureMaterializedForStackWalk as that is needed for ScopedValue when recovering from SOE. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22064#issuecomment-2476351280
