On Thu, 14 Nov 2024 19:20:55 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> The test is checking to make sure SA will use what is in the bcp register to > determine the current line number rather than just use frame->bcp, which > often is not up to date. It spawns a debuggee that sits in a loop that is 10 > lines of source. The test executes jstack on the debuggee and determines the > current line number from the output. It does this 25 times and expectesto see > at least 5 of the 10 line numbers being hit. There's no guarantee it will hit > at least five. The chances of this not happening are very very low, but > apparently the test has failed a couple of times because only 4 unique lines > were hit. I decided to do the simple fix and just lower the threshhold to 4 > lines. > > Ran locally on linux-x64. Tier1 in progress. This pull request has now been integrated. Changeset: 0b1f5710 Author: Chris Plummer <cjplum...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/0b1f57105d5af72b2cd47fa5c9a2b4e2961318cd Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod 8253440: serviceability/sa/TestJhsdbJstackLineNumbers.java failed with "Didn't find enough line numbers" Reviewed-by: kevinw, lmesnik ------------- PR: https://git.openjdk.org/jdk/pull/22117
