On Mon, 18 Nov 2024 19:22:30 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - space
>> - Missed getBoolean
>
> src/jdk.management/share/classes/com/sun/management/internal/GarbageCollectionNotifInfoCompositeData.java
> line 72:
>
>> 70: Field f = cl.getDeclaredField("builder");
>> 71: f.setAccessible(true);
>> 72: builder = (GcInfoBuilder) f.get(gcNotifInfo.getGcInfo());
>
> Suggestion:
>
> builder = (GcInfoBuilder)f.get(gcNotifInfo.getGcInfo());
OK, it was missing the space before, when moving it around I added the space,
as that's what we normally have. In this directory there is a mixture of the
two styles, with and without spaces. I hope it's OK to let this one migrate to
the more modern style. 8-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22155#discussion_r1848465465
