On Tue, 19 Nov 2024 23:17:48 GMT, William Kemper <[email protected]> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahMarkClosures.hpp line 34:
>>
>>> 32: class ShenandoahHeapRegion;
>>> 33:
>>> 34: class ShenandoahFinalMarkUpdateRegionStateClosure : public
>>> ShenandoahHeapRegionClosure {
>>
>> There is the `shenandoahHeapRegionClosures.hpp` for these, no?
>
> It wasn't the intention that `shenandoahHeapRegionClosures.hpp` should become
> home to all of the `*HeapRegionClosures`.
> `ShenandoahFinalMarkUpdateRegionStateClosure` is shared in a couple of
> implementation files, but not the same as the ones using
> `shenandoahHeapRegionClosures.hpp`. I think
> `ShenandoahUpdateCensusZeroCohortClosure` should be moved into the only
> implementation file that uses it.
https://bugs.openjdk.org/browse/JDK-8344779
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1852709824
