> This PR fixes a long-standing bug in JDWP where the access flags of a field > are not checked before attempting to read it's value. > > Prior to this change, attempting to read a non-static field would cause a JVM > crash, this change corrects that behaviour by returning `INVALID_FIELDID` > instead. > > This is my first PR to OpenJDK, so please let me know if I've made any > mistakes in the process. > > Cheers, > Adam
Adam Bruce has updated the pull request incrementally with one additional commit since the last revision: Move static check to sharedGetFieldValues, add JDWP tests ------------- Changes: - all: https://git.openjdk.org/jdk/pull/22280/files - new: https://git.openjdk.org/jdk/pull/22280/files/336bcdf4..88cd6e2d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=22280&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22280&range=00-01 Stats: 1113 lines in 8 files changed: 1097 ins; 12 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/22280.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22280/head:pull/22280 PR: https://git.openjdk.org/jdk/pull/22280
