On Tue, 3 Dec 2024 20:16:33 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> The root cause of [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) > seems to be some JNI Checker warnings. I decided to resolve all the warnings > in the debug agent and debugger tests that start with "in native method". > This seems to have resolved > [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) failure. There are > still other JNI Checker warnings present that are not being dealt with at > this time. > > Testing: > - [x] All tier1 > - [x] All tier2 svc tests > - [x] All tier3 svc tests > - [x] All tier4, which is where > [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) reproduced > - [x] All tier5 svc tests Mostly seems okay but one issue with the exception clearing. Thanks src/jdk.jdwp.agent/share/native/libjdwp/ModuleReferenceImpl.c line 56: > 54: JNI_FUNC_PTR(env,ExceptionClear)(env); // keep -Xcheck:jni happy > 55: ERROR_MESSAGE(("JNI Exception occurred calling > Module.getName()")); > 56: EXIT_ERROR(AGENT_ERROR_JNI_EXCEPTION, NULL); Don't you want to report what the exception was? ------------- PR Review: https://git.openjdk.org/jdk/pull/22528#pullrequestreview-2477106633 PR Review Comment: https://git.openjdk.org/jdk/pull/22528#discussion_r1868595575
