On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim <d...@openjdk.org> wrote:

>> The return value of Metrics#getCpuSetCpus may change over time, including 
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add comment

Hi, 
This looks fine, I'm sure it's ok to proceed without waiting for a re-review 
from Roger about the comment.

It would be good to see the "Checks" tab show more than just jcheck.
Looks like this needs to be enabled in the personal fork.
https://wiki.openjdk.org/display/SKARA/Testing

Then we get some basic builds and tests done for us, and can go ahead with 
(even more) confidence!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527418181

Reply via email to