On Tue, 10 Dec 2024 20:36:25 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove "jvm support" > > src/hotspot/share/oops/arrayKlass.hpp line 123: > >> 121: >> 122: // jvm support >> 123: jint compute_modifier_flags() const; > > I would have expected this to be defined as a virtual function here and then > overridden as needed by the various subclasses. I moved the TypeArrayKlass modifiers to apply to TypeArrayKlass, so they're not accidentally used for ObjArrayKlass, or any other new ArrayKlass that should have different modifiers. I made the virtual function be defined for the most specific class. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22618#discussion_r1878922185
