On Fri, 13 Dec 2024 12:18:13 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> We should output more information about the JVMTI agents in the hserr file.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> simplify coding
Nice enhancement! Could you add an example output to the description, please?
src/hotspot/share/runtime/os.cpp line 1144:
> 1142: if (pathinfo == nullptr) pathinfo = "none";
> 1143: // jplis output too?
> 1144: st->print_cr("%s path:%s, %s, %s %s %s options:%s",
> agent->name(), pathinfo, loadinfo, initinfo, dyninfo, instrumentinfo,
> optionsinfo);
I think the spaces can be improved by removing them between the "%s"s and added
them to the Strings above.
-------------
PR Review: https://git.openjdk.org/jdk/pull/22706#pullrequestreview-2502484830
PR Review Comment: https://git.openjdk.org/jdk/pull/22706#discussion_r1884056284
