On Wed, 18 Dec 2024 03:12:14 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the >> specified FramePop event was already requested. This makes it consistent >> with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt >> to add a breakpoint request that was already requested. >> >> CSR: [8346460](https://bugs.openjdk.org/browse/JDK-8346460): NotifyFramePop >> should return JVMTI_ERROR_DUPLICATE >> >> Testing: >> - tested with mach5 tiers 1-6 > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > review: minor tweak in jvmti.xml update test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/libMethodExitTest.cpp line 500: > 498: cname = get_method_class_name(jvmti, jni, method); > 499: > 500: LOG("\nHit #%d: VirtualThreadUnmount #%d: enabling FramePop for > method: %s::%s on virtual thread: %p\n", The comment needs to be updated as NotifyFramePop is removed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22798#discussion_r1890741942
