On Tue, 7 Jan 2025 04:19:05 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Test nsk/jvmti/ResourceExhausted/resexhausted003 limits metaspace size. 9m >> is not enough if sharing classes are disabled. >> It starts failing with -XX:+UseCompactObjectHeaders just because CDS >> archives are no built this mode. Never executed with CDS off before. >> >> Verified that it pass now with CDS off with and without >> UseCompactObjectHeaders. >> >> I removed also other heap limits just because they are not needed and only >> might confuse test readers. > > test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TestDescription.java > line 43: > >> 41: * -agentlib:resexhausted=-waittime=5 >> 42: * -Xms64m >> 43: * -Xmx64m > > Don't you need these to ensure we get OOME in a reasonable amount of time on > systems with huge memories? The test trigger OOME in Metaspace only by loading classes, so heap shouldn't be used. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22936#discussion_r1904900729
