On Fri, 17 Jan 2025 23:12:14 GMT, William Kemper <wkem...@openjdk.org> wrote:
> This occurs when an attempt to produce a heap dump conflicts with a > concurrent cycle. The heap dump vm operation attempts to run a cycle directly > on the VM thread with no regard for the state of the concurrent collection. > Although Shenandoah _is_ technically capable of running an entire _full_ GCs > on the vm thread, I would rather not add another dependency on full GCs, nor > would I like to cancel an in-progress concurrent GC. Instead, Shenandoah will > follow the pattern established ZGC in which the calling thread waits for a > concurrent cycle to complete before taking the heap dump. LGTM 🚢 ------------- Marked as reviewed by ysr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23186#pullrequestreview-2560240341