On Fri, 24 Jan 2025 11:55:23 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> The System Property "jmx.invoke.getters" was added in >> [JDK-4949203](https://bugs.openjdk.org/browse/JDK-4949203) to optionally be >> compatible with a time before JDK-6, when calling invoke on getters and >> setters was permitted. >> >> It should be removed. > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > (C) src/java.management/share/classes/com/sun/jmx/mbeanserver/PerInterface.java line 149: > 147: throws MBeanException, ReflectionException { > 148: > 149: // Construct the exception that we will throw Although your changes look fine, the existing code for constructing this exception is odd in that it artificially introduces a `cause` exception. It seems to mostly want to capture additional msg information, but most of it seems to be duplicated in the msg passed in, and all this could instead just be handled with a single msg constructed at the call site (and the ReflectionException could be allocated at the call site). Also, what it the @SuppressWarnings("removal") for? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23132#discussion_r1929200951
