On Tue, 28 Jan 2025 12:54:31 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/SetLocalVariable/setlocal001/setlocal001.cpp
>> line 78:
>>
>>> 76: err = jvmti_env->SetLocalLong(thr, 1,
>>> 77: table[i].slot, longVal);
>>> 78: if (err != JVMTI_ERROR_NONE && !(is_virtual && err ==
>>> JVMTI_ERROR_OPAQUE_FRAME)) {
>>
>> Maybe add a new API called something `invalidError(err)`. Not necessary, but
>> might be a little better.
>
> Thanks. I was also thinking about this but was not sure it is worth it.
> Will update now as there are two of us now. :)
Refactored now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23314#discussion_r1932229188
