On Wed, 29 Jan 2025 23:15:08 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Two groups of broken links appeared in the latest JDK docs, broken links to >> man pages and broken ietf links. >> >> - The windows tools markdown files were not being converted to HTML because >> they were placed under `windows/man` rather than `share/man`, I've updated >> `Modules.gmk` to pick up their location. >> >> - Contacted ietf, these are the new links to use. >> >> This patch needs to be backported to JDK 24 as the windows tools man pages >> are not generated there either. >> >> Note: the change to `ExtLinksJdk.txt` is because we partly use it to check >> external links, so it needs to be updated alongside the docs. > > make/common/Modules.gmk line 95: > >> 93: SPEC_SUBDIRS += share/specs >> 94: >> 95: MAN_SUBDIRS += share/man windows/man > > Hm, normally I'd say you should use `$(TARGET_OS)/man`, but we typically > generate docs for all platforms at the same time. So I guess this is okay. Hi @magicus we are seeing build failures because linux builds contain man pages for windows-only tools as reported by https://bugs.openjdk.org/browse/JDK-8350137. Would replacing `windows/man` with `$(TARGET_OS)/man` prevent windows-only tools man pages being generated for linux builds? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23351#discussion_r1960715214
