On Wed, 19 Feb 2025 03:14:49 GMT, Vladimir Kozlov <[email protected]> wrote:
> > Basically for these 3 CodeBlob types getName() will no longer include the
> > CodeBlob type.
>
> I think this is fine: output is informative enough to figure out type of
> blob. Please check SA tests if they look for old output.
The tests are all passing.
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/RuntimeStub.java
> line 47:
>
>> 45: private static void initialize(TypeDataBase db) {
>> 46: Type type = db.lookupType("RuntimeStub");
>> 47: callerMustGCArgumentsField =
>> type.getCIntegerField("_caller_must_gc_arguments");
>
> This field is in `CodeBlob` since JDK 23
> [JDK-8329433](https://bugs.openjdk.org/browse/JDK-8329433)
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/code/codeBlob.hpp#L126
Ah, right. I forgot you had mentioned that. I think that means I can rid of
RuntimeStub and RuntimeBlob once this code is moved to CodeBlob.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23684#issuecomment-2667484513
PR Review Comment: https://git.openjdk.org/jdk/pull/23684#discussion_r1960935263
