On Wed, 12 Mar 2025 13:57:43 GMT, snake66 <d...@openjdk.org> wrote: >> Allows for future support for platforms that require different flags for >> libiconv support. >> >> Sponsored-by: The FreeBSD Foundation > > snake66 has updated the pull request incrementally with one additional commit > since the last revision: > > Set ICONV_* flags for aix and macosx only
Also, to double check, are the new variables `ICONV_CFLAGS` and `ICONV_LDFLAGS` going to be non-empty on BSD? There is no reason to introduce a variable for completeness sake, if it is never going to have any value. But it is fully okay if they are empty now, but will have a value for BSD. make/modules/jdk.jdwp.agent/Lib.gmk line 76: > 74: java.base:libjava, \ > 75: JDK_LIBS := java.base:libjvm, \ > 76: LIBS_linux := $(LIBDL), \ Something got wrong here. You should have kept the LIBS_linux line, and the new LIBS line should be `LIBS := $(ICONV_LIBS)`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23995#issuecomment-2718530308 PR Review Comment: https://git.openjdk.org/jdk/pull/23995#discussion_r1991917140
