On Fri, 14 Mar 2025 06:15:40 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address @tstuefe review: >> - Renamed shouldMatchUnconditionally_<os>_libjvm to >> shouldMatch_<os>_libjvm in SystemMapTestBase. >> - Added comments to shouldMatchUnconditionally() methods for difference OS >> cases in SystemMapTestBase. >> - Added comments to DynLibsTest.java. > > Good, thanks for addressing the nits Thanks, @tstuefe! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23734#issuecomment-2725174357