On Tue, 1 Apr 2025 10:30:56 GMT, Varada M <vara...@openjdk.org> wrote:
>> AIX changes for attach API to support arbitrary length arguments and the >> streaming output support. >> serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes >> >> tier1, tier2 and tier3 testing is successful with fastdebug level >> >> JBS Issue : [JDK-8352392](https://bugs.openjdk.org/browse/JDK-8352392) > > Varada M has updated the pull request incrementally with one additional > commit since the last revision: > > 8352392: AIX: implement attach API v2 and streaming output Hi Varada, I see that you've largely adapted the code to the POSIX version. Essentially, only the shutdown special handling remains. But the AIX special handling that you removed was introduced for some reason. Do you know why? Does this reasoning no longer apply? I have no idea and can't judge whether the different semantics have created holes in the code that could reappear under certain circumstances. Therefore, I would like an explanation from you as to why you can make this change now. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24177#issuecomment-2772207203
