On Thu, 10 Apr 2025 23:28:24 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> Don't use includevirtualthreads=y unless the test requires it. Debuggers 
>> don't usually use includevirtualthreads=y, so we should be doing most of our 
>> testing without it. The only reason tests use it is because some tests need 
>> it so they can find virtual threads in the debuggee by using 
>> vm.allThreads(). This change limits the use of includevirtualthreads=y to 
>> just those com/sun/jdi tests that need it.
>> 
>> Tested by running com/sun/jdi tests on all supported platforms in both 
>> platform threads mode and virtual threads mode. Also tested with tier1 CI.
>
> Chris Plummer has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix copyright.

Marked as reviewed by amenkov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24583#pullrequestreview-2774074451

Reply via email to