On Mon, 28 Apr 2025 19:30:27 GMT, Kevin Walls <kev...@openjdk.org> wrote:

>> This issue was hard to reproduce or had stopped happening, but was likely a 
>> failure to capture the main arguments from a monitored process, caused by 
>> slow startups e.g. -Xcomp.  Recent failures seen in Graal testing are most 
>> likely the same issue and increasing ARGS_ATTEMPTS has been seen to resolve 
>> it.
>> 
>> While updating the test, fix the very verbose logging: it doesn't need to 
>> log, every second, how many nanos it has waited.
>> This has made logs from timeouts hardly usable as they are truncated and may 
>> miss critical info.  Also, group the "tunable" constants together.
>
> Kevin Walls has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remove unnecessary timeout related lines

Marked as reviewed by cjplummer (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24843#pullrequestreview-2800641600

Reply via email to