On Mon, 28 Apr 2025 23:35:49 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> return null instead of throwing an exception
>
> test/hotspot/jtreg/vmTestbase/nsk/share/jdi/Debugee.java line 463:
>
>> 461: EventSet eventSet = eventQueue.remove(timeLeft);
>> 462: if (eventSet == null) {
>> 463: return null;
>
> This does not match the comment at the line 438:
>
> * Wait for the requested event and skip other events.
What is implied here is waiting for "timeout" ms, not indefinitely. Nothing has
changed in that regard as the method was always intended to return after the
timeout expires.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24839#discussion_r2065207036
