On Thu, 1 May 2025 15:49:49 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> I do like having the Exception created at the point where we recognise >> there's a problem. While the message could hard-code in the -1 in the >> Windows case, it must be also good to use the same expression to build the >> message, right next to each other. >> I also like keeping the existing Exception wording, there isn't a real need >> to change it. >> It's still a tiny little test routine and on future failure on Windows, it >> should be clear that we didn't receive any good values. >> On balance would you be OK if we leave as it stands? > > sure, let left it as it is. > Let return to this once 2019 is going to be EOL and remove all this stuff: > Looks good for me. Thanks Leonid! Eventually there were a few failures on other Windows versions, so I removed the specific mention of Windows 2019, although it was most common. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24961#discussion_r2070440202
