On Tue, 6 May 2025 08:36:44 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> It feels like all the `HandshakeState` SR code can be moved from >> `handshake.?pp` to` jvmtiEnvBase.?pp` as it seems to be a little bit >> unnatural for `HandshakeState`. The `JvmtiThreadState_lock` or some other >> lock can be used for waiting in the suspended state. Then some attempts to >> simplify this code could be made. But it does not look as very important at >> this point in time. > > I've pushed the fix suggested above. Please, let me know if it looks right or > not. Great. Yes, that was the suggestion. I didn't think about renaming the parameter but I like the new name. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24269#discussion_r2075844072
