On Tue, 13 May 2025 22:11:25 GMT, Alex Menkov <amen...@openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   fix comment to reference threadByFieldName()
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002.java line 
> 119:
> 
>> 117: 
>> 118:         // debuggee main class
>> 119:         mainClass = debuggee.classByName(DEBUGGEE_CLASS);
> 
> Maybe just move this into `try` and replace `debuggee.threadByFieldName` with 
> `debuggee.threadByFieldNameOrThrow`?

@alexmenkov It looks like this could be done in almost every test in this PR. 
In some the `try` just needs to move about 8 lines up, but in others it's more 
like 20. There will be a lot of indentation diffs. Do you still want to see 
this change?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25190#discussion_r2092082041

Reply via email to