On Thu, 22 May 2025 19:51:43 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The change fixes failure of
>> vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java test.
>> The test was problem-listed in jdk 11 due intermittent timeouts, but in
>> jdk15-16 changes in nsk framework made the test fail 100% (it wasn't noticed
>> as the test was problemlisted)
>> The problem is attach045 has "target" parameter which contain class name and
>> arguments (all other tests have only class name), and value of the argument
>> is passed in surrounding quotes, so target application fails with
>> ClassNotFoundException.
>> Now I cannot reproduce original test failure, so removing the test from
>> problemlist
>
> test/hotspot/jtreg/vmTestbase/nsk/share/aod/AODRunnerArgParser.java line 109:
>
>> 107: }
>> 108:
>> 109: String target = options.getProperty(TARGET_APP_PARAM);
>
> I think it is better to remove -classPath from parameters and
> use
> ${test.class.path}
> directly in the test.
The test is run by `nsk.share.aod.AODTestRunner` which runs test app specified
by "target" argument.
Target apps have no system properties like test.class.path
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25366#discussion_r2103363348
