On Mon, 26 May 2025 09:44:30 GMT, Johannes Bechberger <jbechber...@openjdk.org>
wrote:
>> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 601:
>>
>>> 599:
>>> 600: if (jt->thread_state() == _thread_in_native &&
>>> 601: tl->cpu_time_jfr_queue().size() >
>>> tl->cpu_time_jfr_queue().capacity() * 2 / 3) {
>>
>> Is this testing what you intend? The precedence order is [*, / ], from left
>> to right associativity
>
> I can't follow. This is testing whether the queue is more than two thirds
> full.
I'm sorry, I read this wrong. In this case, it does not matter: (capacity * 2)
/ 3 == capacity * (2/3)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2107027793
