On Wed, 28 May 2025 07:07:27 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move to ThreadService
>
> src/hotspot/share/services/threadService.cpp line 1170:
>
>> 1168: };
>> 1169:
>> 1170: Handle _java_thread;
>
> Suggestion:
>
> Handle h_java_thread;
>
> The use of the `h_` prefix for a variable that is a handle is not uncommon
> and makes it clearer it is a handle, especially when applying the `()`
> operator.
I'm going to rename the fields as Serguei suggested (so this will be `Handle
_thread_h`)
> src/hotspot/share/services/threadService.cpp line 1203:
>
>> 1201: }
>> 1202:
>> 1203: bool read_reset_retry() {
>
> What does the `read` mean in the name?
read and then reset the `retry` value (return old value)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2112513006
PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2112517968
