On Thu, 22 May 2025 17:55:07 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> Hi,
>>
>> The constant pool currently has a lot of methods specific to extracting
>> parts of the operands array. What this array actually is, is a sequence of
>> bootstrap method attribute entries, where each entry has the following
>> components:
>>
>> ```c++
>> struct BSMAE {
>> u2 bootstrap_method_index;
>> u2 argument_count;
>> u2 arguments[argument_count];
>> }
>>
>>
>> We can removes some of these operands array specific methods, and instead
>> allows you to extract BSMAttributeEntrys which you can then use to extract
>> its piece wise components. This makes for a nicer interface, and a bit
>> easier to come into as a reader of the code, as it more closely mirrors the
>> JVMS.
>>
>> Please consider!
>>
>> Testing: Currently GHA, running tier1-tier3
>
> Johan Sjölen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Lois's comments
Hi,
> I think this looks like a nice improvement but I thought operands was going
> to turn into two arrays? Also there's probably a better name than 'operands'
> maybe bsm_operands?
Yeah, I hope to do that in a future PR.
Re: SA mirror constants. OK, I can do that, that makes sense.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25298#issuecomment-2955581389
