On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper <wkem...@openjdk.org> wrote:
> We can remove `GCCause::_no_cause_specified` and need to add a case for
> `_shenandoah_humongous_allocation_failure` in `GCCause::to_string`. We are
> also missing `_shenandoah_humongous_allocation_failure` in the `SA` analog.
Reviewed -- would be good to go from my standpoint after separating into a
separate ticket as suggested by Aleksey the collapse of `no_cause_specified`
into its putative synonym `_no_gc`.
Approving in advance, subject to that change, and re-review by Aleksey.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/GCCause.java line
42:
> 40:
> 41: _no_gc ("No GC"),
> 42: _no_cause_specified ("Unknown GCCause"),
I agree that "no cause specified" and "no gc" almost sound like synonyms, and
any uses of one could be replaced with the other. However, with @shipilev , I
agree that may be you split the changes to this kind of shared code into a
separate ticket, in keeping with hotspot dev practices.
-------------
Marked as reviewed by ysr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25789#pullrequestreview-2926250505
PR Review Comment: https://git.openjdk.org/jdk/pull/25789#discussion_r2146013368
