On Thu, 12 Jun 2025 18:01:26 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> The nsk BindServer class is no longer used so it can be removed. This appears > to be a remnant left over after the following recent change: > > [JDK-8333117](https://bugs.openjdk.org/browse/JDK-8333117) Remove support of > remote and manual debuggee launchers > > There is also some additional cleanup of "manual" and "remote" debuggee > launchers done by this PR and fixing some comments that have been wrong for a > long time regarding "see also". > > Tested by running nsk/jdi, nsk/jdb, and nsk/jdwp tests locally. I'll also run > them with tier5 CI once reviews have been done. test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java line 35: > 33: /** > 34: * This class provides launching of <code>jdb</code> and debuggee in local > 35: * mode according to test command line options. As now there is only local mode, I think there is no sense to mention it at all: * This class provides launching of <code>jdb</code> and debuggee * according to test command line options. test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java line 97: > 95: > 96: /** > 97: * Defines mode (local) and type of connector (default, launching, Suggestion: * Defines type of connector (default, launching, test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java line 44: > 42: * debugee VM process. > 43: * Derived classes should implement these methods corresponding to the > mode > 44: * that the process should be started in (locally). I think this can be dropped test/hotspot/jtreg/vmTestbase/nsk/share/jpda/IOPipe.java line 32: > 30: * This class implements communicational channel between > 31: * debugger and debugee used for synchronization and data exchange. > 32: * This channel is based on TCP/IP socketss. Suggestion: * This channel is based on TCP/IP sockets. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25785#discussion_r2146271592 PR Review Comment: https://git.openjdk.org/jdk/pull/25785#discussion_r2146272505 PR Review Comment: https://git.openjdk.org/jdk/pull/25785#discussion_r2146275444 PR Review Comment: https://git.openjdk.org/jdk/pull/25785#discussion_r2146276315
