On Mon, 19 May 2025 07:35:16 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
> Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > components: > > ```c++ > struct BSMAE { > u2 bootstrap_method_index; > u2 argument_count; > u2 arguments[argument_count]; > } > > > We can removes some of these operands array specific methods, and instead > allows you to extract BSMAttributeEntrys which you can then use to extract > its piece wise components. This makes for a nicer interface, and a bit easier > to come into as a reader of the code, as it more closely mirrors the JVMS. > > Please consider! > > Testing: Currently GHA, running tier1-tier3 This pull request has now been integrated. Changeset: 3d35b408 Author: Johan Sjölen <jsjo...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/3d35b408e1e69d7e3953af142c5bf606691fbeb8 Stats: 115 lines in 7 files changed: 42 ins; 31 del; 42 mod 8357220: Introduce a BSMAttributeEntry struct Co-authored-by: John R Rose <jr...@openjdk.org> Reviewed-by: sspitsyn, coleenp, matsaave ------------- PR: https://git.openjdk.org/jdk/pull/25298