On Wed, 25 Jun 2025 06:34:10 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> Update SA to know about JfrRecorderThread, which was made a JavaThread in 
>> JDK 25 by [JDK-8352251](https://bugs.openjdk.org/browse/JDK-8352251).
>> 
>> I'm also fixing ClhsdbJstackWithConcurrentLock, which was also failing with 
>> JFR enabled, but for a different reason (specified heap size was too small).
>> 
>> Testing (in progress):
>> 
>> - [x] tier1 ci
>> - [x] tier1 ci with -XX:StartFlightRecording 
>> - [x] tier5 ci
>
> Chris Plummer has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix copyright

Marked as reviewed by kevinw (Reviewer).

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Threads.java line 
200:

> 198:             " (expected type JavaThread, CompilerThread, 
> MonitorDeflationThread, AttachListenerThread," +
> 199:             " DeoptimizeObjectsALotThread, StringDedupThread, 
> NotificationThread, ServiceThread," +
> 200:             "JfrRecorderThread, or JvmtiAgentThread)", e);

nitpicking: space?

-------------

PR Review: https://git.openjdk.org/jdk/pull/25960#pullrequestreview-2957100831
PR Review Comment: https://git.openjdk.org/jdk/pull/25960#discussion_r2166077918

Reply via email to