On Fri, 27 Jun 2025 19:02:46 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8284016: Realigned parameters
>
> src/hotspot/share/prims/jvmtiEnvBase.hpp line 511:
>
>> 509: };
>> 510:
>> 511: class SetForceEarlyReturnHandshakeClosure : public
>> JvmtiUnitedHandshakeClosure {
>
> I do not support this unification over JVMTI files. This make
> `HandshakeClosure` class names too long.
> The JVMTI has a consistent local naming convention to have the suffix
> `Closure` at the end instead of `HandshakeClosure`. And it is fine because
> normally there are no other kind of closures in JVMTI code.
@sspitsyn How about this: instead of xxxHandshakeClosure put xxxHSClosure? HS
would stand for Handshake, but the length will increase by only 2 symbols.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2174425304
