On Fri, 25 Jul 2025 18:06:38 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move comment
>
> Thumbs up on the changes. I think I only have a few nits.
Thanks for the review @dcubed-ojdk !
Just need one Reviewer to re-review the nit fix-ups. Thanks
> src/hotspot/share/runtime/threadSMR.cpp line 833:
>
>> 831: return false;
>> 832: } else {
>> 833: // For virtual thread's we need to extract the carrier's
>> JavaThread - if any.
>
> nit typo: s/thread's/threads/
Fixed
> src/hotspot/share/runtime/threadSMR.hpp line 72:
>
>> 70: // : // do stuff with 'jt'...
>> 71: //
>> 72: // A JavaThread* that is included in the ThreadsList that is held by
>
> Why change just this location from `JavaThread *` to `JavaThread*`?
> There are other places that you touched that still use `JavaThread *`.
I started changing them all but changed my mind - I missed reverting this one.
Fixed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26287#issuecomment-3124739300
PR Review Comment: https://git.openjdk.org/jdk/pull/26287#discussion_r2234139881
PR Review Comment: https://git.openjdk.org/jdk/pull/26287#discussion_r2234140216
