On Wed, 30 Jul 2025 14:47:54 GMT, Lei Zhu <d...@openjdk.org> wrote:
> Hi all,
>
> `ProcessTools.createTestJavaProcessBuilder(String... command)` will call
> `jdk.test.lib.Utils#getTestJavaOpts`, so remove the duplicate vm flags.
> Trivial fix.
>
> Thanks!
Changes requested by lmesnik (Reviewer).
test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java line 183:
> 181:
> 182: List<String> command = new ArrayList<>();
> 183: Collections.addAll(command, Utils.getTestJavaOpts());
Comment generic to all three test fixes:
Shouldn't be
command.add(TEST_CLASS_PATH);
command.add(className);
also removed?
The ProcessTools.createTestJavaProcessBuilder(command);
uses standard classpath that should fit this test needs.
If needed,
property "test.noclasspath", mgith be use to don't add classpath. See
jdk/test/lib/process/ProcessTools.java:161
private static ProcessBuilder createJavaProcessBuilder(String... command) {
...
String noCPString = System.getProperty("test.noclasspath", "false");
-------------
PR Review: https://git.openjdk.org/jdk/pull/26555#pullrequestreview-3073452917
PR Review Comment: https://git.openjdk.org/jdk/pull/26555#discussion_r2243946685
