On Thu, 31 Jul 2025 15:49:02 GMT, Patricio Chilano Mateo
<pchilanom...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed typo: in latest update
>
> src/hotspot/share/prims/jvm.cpp line 2899:
>
>> 2897: // An asynchronous exception could have been thrown on
>> 2898: // us while we were sleeping. We do not overwrite those.
>> 2899: if (!HAS_PENDING_EXCEPTION) {
>
> Maybe not for this bug but we have this `HAS_PENDING_EXCEPTION` check here
> and further up but I don't see how we can have a pending exception when
> calling this method. Based on the comment here seems we just wanted to check
> the async ones as added now.
Should we always have `HAS_PENDING_EXCEPTION == true` if async exception was
installed?
If so, then this newly added check is not really needed:
if (!thread->has_async_exception_condition()) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26365#discussion_r2247472186
