On Tue, 19 Aug 2025 21:17:16 GMT, Patricio Chilano Mateo <[email protected]> wrote:
>> Leonid Mesnik has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains nine additional >> commits since the last revision: >> >> - The oop preservation and exception handling has been fixed. >> - Test added. >> - Merge branch 'master' of https://github.com/openjdk/jdk into 8365192 >> - Merge branch 'master' of https://github.com/openjdk/jdk into 8365192 >> - added _ >> - wong phase >> - fixed name >> - simplified after feedback >> - 8365192: post_meth_exit should be in vm state when calling >> get_jvmti_thread_state > > test/hotspot/jtreg/serviceability/jvmti/events/MethodExit/ExceptionOccurred.java > line 1: > >> 1: /* > > Shouldn't this file be placed in > `test/hotspot/jtreg/serviceability/jvmti/events/MethodExit/ExceptionOccurred` > along with the cpp file? It makes test name serviceability/jvmti/events/MethodExit/ExceptionOccurred/ExceptionOccurred.java so it is better to left it on this level And tests usually have single lib*.cpp per directory. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26713#discussion_r2286597518
