On Wed, 3 Sep 2025 01:49:04 GMT, SendaoYan <s...@openjdk.org> wrote: >> Hi all, >> >> Test com/sun/jdi/JdbStopInNotificationThreadTest.java fails "Exception >> thrown during test execution: waitForPrompt timed out after 60 seconds" >> after JDK-8260555 change the default timeout factor from 4 to 1. Before >> JDK-8260555, the "waitForPrompt timed out" value if calculate from >> `Utils.adjustTimeout(60000)` in >> [test/jdk/com/sun/jdi/lib/jdb/Jdb.java](https://github.com/openjdk/jdk/blob/master/test/jdk/com/sun/jdi/lib/jdb/Jdb.java#L80), >> it will [multiply the timeout >> factor](https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/Utils.java#L468) >> . >> >> This PR add '-Xmx64' to make debugee JVM to finish the java heap allocation >> quickly. >> >> Change has been verified locally, no risk. > > SendaoYan has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Merge branch 'openjdk:master' into jbs8366694 > - Use addDebuggeeOptions(-Xmx64) to make test run quickly, instead of add > timeout value > - 8366694: Test JdbStopInNotificationThreadTest.java timed out after 60 > second
Marked as reviewed by ayang (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/27055#pullrequestreview-3179406348
