On Thu, 4 Sep 2025 03:06:29 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> This PR is one (of many) steps in >> [JDK-8366473](https://bugs.openjdk.org/browse/JDK-8366473) (Refactor CDS >> source code with new AOT terminology): >> >> Rename `is_shared()` in `Metaspace` (and various other classes) to >> `in_aot_cache()` to reflect its true meaning: >> - tests if an object is inside the AOT cache's metaspace region. >> >> Also various forms of "shared metaspace" are updated to "aot metaspace" >> >> Please start your review with allocations.hpp > > Ioi Lam has updated the pull request with a new target base due to a merge or > a rebase. The pull request now contains four commits: > > - Also renamed ConstantPool::is_shared() because it shadows > MetaspaceObj::is_shared() > - Merge branch 'master' into > 8366474-rename_metaspaceobj_is_shared_to_in_aot_cache > - Removed MetaspaceShared -> AOTMetaspace changes that are intended for > https://github.com/openjdk/jdk/pull/27017 > - 8366474: Rename MetaspaceObj::is_shared() to MetaspaceObj::in_aot_cache()
The subsequent fix looks good. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27016#pullrequestreview-3183291587
